croc file overwrite in receive-side text transfer handling
schollz croc
Affected versions
| Product | Affected | Fixed in |
|---|---|---|
| github.com/schollz/croc/v11 Go |
|
|
| github.com/schollz/croc/v10 Go |
| No fix yet |
| github.com/schollz/croc/v9 Go |
|
schollz croc
| Product | Affected | Fixed in |
|---|---|---|
| github.com/schollz/croc/v11 Go |
|
|
| github.com/schollz/croc/v10 Go |
| No fix yet |
| github.com/schollz/croc/v9 Go |
|
| No fix yet |
| github.com/schollz/croc/v8 Go |
| No fix yet |
| github.com/schollz/croc/v6 Go |
| No fix yet |
| github.com/schollz/croc Go |
| No fix yet |
croc is a tool that allows any two computers to simply and securely transfer files and folders. Prior to 11.5.2, the receive-side file-readiness loop in src/croc/croc.go treats any sender-controlled basename beginning with croc-stdin- as a trusted text-transfer artifact even when SendingText is false. This skips askReceiveOverwrite and rename handling for a predictable exact-name collision in the receiver's working directory, allowing a remote sender whose transfer the user accepts to overwrite or truncate a matching regular file through recipientInitializeFile, or to remove and replace a matching destination with an empty file or an in-directory symlink through createEmptyFileAndFinish, without confirmation. The impact is limited to pre-existing names in the croc-stdin- namespace that the sender can predict; other filenames retain the prompt, dotfiles outside that namespace are not reachable, and symlink targets remain confined to the receive directory. This issue is fixed in version 11.5.2.
From the CVE record · GitHub_M
The receive-side file-readiness loop trusts sender-controlled filenames beginning with croc-stdin- even when text transfer is disabled. A remote sender whose transfer the user accepts can overwrite, truncate, or replace a matching file in the receiver's working directory without an overwrite prompt. The sender must predict a pre-existing name in that namespace; other filenames retain the prompt.
Anyone running schollz croc with Go package github.com/schollz/croc/v11 before 11.5.2, or the listed affected v10, v9, v8, v6, or unversioned packages, should check their installation.