rpmsg: core: fix race in driver_override_show() and use core helper
Linux
Affected versions
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
Linux
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
≥ 39e47767ec9b22f844c2a07c9d329256960d4021 · < 2e4a70f3c30910427e5ea848b799066d67b963d5| No fix yet |
| Linux Linux |
|
|
In the Linux kernel, the following vulnerability has been resolved:
rpmsg: core: fix race in driver_override_show() and use core helper
The driver_override_show function reads the driver_override string without holding the device_lock. However, the store function modifies and frees the string while holding the device_lock. This creates a race condition where the string can be freed by the store function while being read by the show function, leading to a use-after-free.
To fix this, replace the rpmsg_string_attr macro with explicit show and store functions. The new driver_override_store uses the standard driver_set_override helper. Since the introduction of driver_set_override, the comments in include/linux/rpmsg.h have stated that this helper must be used to set or clear driver_override, but the implementation was not updated until now.
Because driver_set_override modifies and frees the string while holding the device_lock, the new driver_override_show now correctly holds the device_lock during the read operation to prevent the race.
Additionally, since rpmsg_string_attr has only ever been used for driver_override, removing the macro simplifies the code.
From the CVE record · Linux
The Linux kernel's rpmsg driver_override_show() reads a string without holding the device lock, while a concurrent write can free it. An attacker who can trigger concurrent reads and writes of driver_override could cause a use-after-free; the input does not specify authentication or further interaction requirements.
Engineers running the Linux kernel should check whether their build includes the affected rpmsg code; affected versions are not specified.