rust_binder: remove spin_lock() in rust_shrink_free_page()
Linux
Affected versions
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
| No fix yet |
| Linux Linux |
|
|
Linux
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
| No fix yet |
| Linux Linux |
|
|
In the Linux kernel, the following vulnerability has been resolved:
rust_binder: remove spin_lock() in rust_shrink_free_page()
When forward-porting Rust Binder to 6.18, I neglected to take commit fb56fdf8b9a2 ("mm/list_lru: split the lock to per-cgroup scope") into account, and apparently I did not end up running the shrinker callback when I sanity tested the driver before submission. This leads to crashes like the following:
============================================ WARNING: possible recursive locking detected 6.18.0-mainline-maybe-dirty #1 Tainted: G IO -------------------------------------------- kswapd0/68 is trying to acquire lock: ffff956000fa18b0 (&l->lock){+.+.}-{2:2}, at: lock_list_lru_of_memcg+0x128/0x230
but task is already holding lock: ffff956000fa18b0 (&l->lock){+.+.}-{2:2}, at: rust_helper_spin_lock+0xd/0x20
other info that might help us debug this: Possible unsafe locking scenario:
CPU0 ---- lock(&l->lock); lock(&l->lock);
*** DEADLOCK ***
From the CVE record · Linux
The Rust Binder shrinker can try to acquire a lock it already holds, causing a possible deadlock or crash. The issue was found during a forward-port to Linux 6.18; the input does not describe an attacker, access requirements, or user interaction.
Engineers running Linux kernels with the affected Rust Binder forward-port to 6.18 should check their builds.