can: j1939: implement NETDEV_UNREGISTER notification handler
Linux
Affected versions
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
Linux
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
≥ 9d71dd0c70099914fcd063135da3c580865e924c · < 7fcbe5b2c6a4b5407bf2241fdb71e0a390f6ab9a| No fix yet |
| Linux Linux |
|
|
In the Linux kernel, the following vulnerability has been resolved:
can: j1939: implement NETDEV_UNREGISTER notification handler
syzbot is reporting
unregister_netdevice: waiting for vcan0 to become free. Usage count = 2
problem, for j1939 protocol did not have NETDEV_UNREGISTER notification handler for undoing changes made by j1939_sk_bind().
Commit 25fe97cb7620 ("can: j1939: move j1939_priv_put() into sk_destruct callback") expects that a call to j1939_priv_put() can be unconditionally delayed until j1939_sk_sock_destruct() is called. But we need to call j1939_priv_put() against an extra ref held by j1939_sk_bind() call (as a part of undoing changes made by j1939_sk_bind()) as soon as NETDEV_UNREGISTER notification fires (i.e. before j1939_sk_sock_destruct() is called via j1939_sk_release()). Otherwise, the extra ref on "struct j1939_priv" held by j1939_sk_bind() call prevents "struct net_device" from dropping the usage count to 1; making it impossible for unregister_netdevice() to continue.
[mkl: remove space in front of label]
From the CVE record · Linux
The Linux kernel’s CAN J1939 protocol fails to release a reference held by a bound socket when its network device is unregistered. This can prevent device unregistration from completing. The input does not establish an attacker path, authentication requirement, or need for user interaction.
Engineers running Linux kernels that use CAN J1939 should check their kernel; affected versions are not specified.