dmaengine: idxd: Fix double free in idxd_setup_wqs()
Linux
Affected versions
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
Linux
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
ed2c66000aa64c0d2621864831f0d04c820a1441| No fix yet |
| Linux Linux |
|
|
In the Linux kernel, the following vulnerability has been resolved:
dmaengine: idxd: Fix double free in idxd_setup_wqs()
The clean up in idxd_setup_wqs() has had a couple bugs because the error handling is a bit subtle. It's simpler to just re-write it in a cleaner way. The issues here are:
1) If "idxd->max_wqs" is <= 0 then we call put_device(conf_dev) when "conf_dev" hasn't been initialized. 2) If kzalloc_node() fails then again "conf_dev" is invalid. It's either uninitialized or it points to the "conf_dev" from the previous iteration so it leads to a double free.
It's better to free partial loop iterations within the loop and then the unwinding at the end can handle whole loop iterations. I also renamed the labels to describe what the goto does and not where the goto was located.
From the CVE record · Linux
The Linux kernel's idxd_setup_wqs() cleanup can use an uninitialized device reference when max_wqs is zero or less, or an invalid reference when kzalloc_node() fails. The allocation-failure path can cause a double free. The input does not specify how an attacker could reach these conditions or whether authentication or user interaction is required.
Engineers running the Linux kernel with the idxd dmaengine driver should check their kernel; affected versions were not provided.