xfs: do not propagate ENODATA disk errors into xattr code
Linux
Affected versions
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
Linux
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
≥ 07120f1abdff80f3d1351f733661abe28d609535 · < 39fc2742ca14f7fbc621ce9b43bcbd00248cb9a8| No fix yet |
| Linux Linux |
|
|
In the Linux kernel, the following vulnerability has been resolved:
xfs: do not propagate ENODATA disk errors into xattr code
ENODATA (aka ENOATTR) has a very specific meaning in the xfs xattr code; namely, that the requested attribute name could not be found.
However, a medium error from disk may also return ENODATA. At best, this medium error may escape to userspace as "attribute not found" when in fact it's an IO (disk) error.
At worst, we may oops in xfs_attr_leaf_get() when we do:
error = xfs_attr_leaf_hasname(args, &bp); if (error == -ENOATTR) { xfs_trans_brelse(args->trans, bp); return error; }
because an ENODATA/ENOATTR error from disk leaves us with a null bp, and the xfs_trans_brelse will then null-deref it.
As discussed on the list, we really need to modify the lower level IO functions to trap all disk errors and ensure that we don't let unique errors like this leak up into higher xfs functions - many like this should be remapped to EIO.
From the CVE record · Linux
The Linux kernel’s XFS extended-attribute code can mistake a disk medium error for an attribute-not-found result. If an extended-attribute lookup encounters that error, the kernel may dereference a null pointer and crash; before commit 07120f1abdff, it instead returned the wrong error to userspace. The input does not establish an attacker access or authentication requirement.
Engineers running Linux kernels with XFS should check their kernel’s status; affected versions are not specified.