sch_htb: make htb_deactivate() idempotent
Linux
Affected versions
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
Linux
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
≥ 0a188c0e197383683fd093ab1ea6ce9a5869a6ea · < 98cd7ed92753090a714f0802d4434314526fe61d| No fix yet |
| Linux Linux |
| No fix yet |
In the Linux kernel, the following vulnerability has been resolved:
sch_htb: make htb_deactivate() idempotent
Alan reported a NULL pointer dereference in htb_next_rb_node() after we made htb_qlen_notify() idempotent.
It turns out in the following case it introduced some regression:
htb_dequeue_tree(): |-> fq_codel_dequeue() |-> qdisc_tree_reduce_backlog() |-> htb_qlen_notify() |-> htb_deactivate() |-> htb_next_rb_node() |-> htb_deactivate()
For htb_next_rb_node(), after calling the 1st htb_deactivate(), the clprio[prio]->ptr could be already set to NULL, which means htb_next_rb_node() is vulnerable here.
For htb_deactivate(), although we checked qlen before calling it, in case of qlen==0 after qdisc_tree_reduce_backlog(), we may call it again which triggers the warning inside.
To fix the issues here, we need to:
From the CVE record · Linux
The Linux kernel’s sch_htb code can dereference a NULL pointer during HTB dequeue when backlog reduction deactivates a class before htb_next_rb_node() runs. An attacker able to trigger this path could cause the dereference; the required access, authentication and user interaction are not specified.
Anyone running a Linux kernel with the affected sch_htb code should check their kernel; affected versions are not specified.