usb: xhci: Fix invalid pointer dereference in Etron workaround
Linux
Affected versions
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
Linux
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
| No fix yet |
| Linux Linux |
|
|
In the Linux kernel, the following vulnerability has been resolved:
usb: xhci: Fix invalid pointer dereference in Etron workaround
This check is performed before prepare_transfer() and prepare_ring(), so enqueue can already point at the final link TRB of a segment. And indeed it will, some 0.4% of times this code is called.
Then enqueue + 1 is an invalid pointer. It will crash the kernel right away or load some junk which may look like a link TRB and cause the real link TRB to be replaced with a NOOP. This wouldn't end well.
Use a functionally equivalent test which doesn't dereference the pointer and always gives correct result.
Something has crashed my machine twice in recent days while playing with an Etron HC, and a control transfer stress test ran for confirmation has just crashed it again. The same test passes with this patch applied.
From the CVE record · Linux
The Linux kernel’s USB xHCI Etron workaround can dereference an invalid pointer when a transfer is queued at the final link TRB of a segment. This can crash the kernel; the report reproduced the crash with a control-transfer stress test on an Etron host controller. The input does not establish whether an attacker can trigger it or what access they would need.
Engineers running Linux kernels with an Etron USB host controller should check whether their kernel includes the fix; affected versions are not specified.