watch_queue: fix pipe accounting mismatch
Linux
Affected versions
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
Linux
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
≥ e95aada4cb93d42e25c30a0ef9eb2923d9711d4a · < 2d680b988656bb556c863d8b46d9b9096842bf3d| No fix yet |
| Linux Linux |
|
|
In the Linux kernel, the following vulnerability has been resolved:
watch_queue: fix pipe accounting mismatch
Currently, watch_queue_set_size() modifies the pipe buffers charged to user->pipe_bufs without updating the pipe->nr_accounted on the pipe itself, due to the if (!pipe_has_watch_queue()) test in pipe_resize_ring(). This means that when the pipe is ultimately freed, we decrement user->pipe_bufs by something other than what than we had charged to it, potentially leading to an underflow. This in turn can cause subsequent too_many_pipe_buffers_soft() tests to fail with -EPERM.
To remedy this, explicitly account for the pipe usage in watch_queue_set_size() to match the number set via account_pipe_buffers()
(It's unclear why watch_queue_set_size() does not update nr_accounted; it may be due to intentional overprovisioning in watch_queue_set_size()?)
From the CVE record · Linux
The Linux kernel's watch_queue_set_size() can charge pipe buffers to a user without updating the pipe's accounted total. When the pipe is freed, the mismatch can underflow the user's pipe-buffer count and cause later pipe-buffer checks to fail with -EPERM. The input does not establish whether an attacker can trigger this, or specify authentication or user-interaction requirements.
Engineers running Linux kernels with watch_queue support should check their versions; affected versions are not specified.