PCI/ASPM: Fix link state exit during switch upstream function removal
Linux
Affected versions
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
Linux
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
≥ 456d8aa37d0f56fc9e985e812496e861dcd6f2f2 · < f556b6ba0ac5f8353287ce6ed761228f0b4fafb7| No fix yet |
| Linux Linux |
|
|
In the Linux kernel, the following vulnerability has been resolved:
PCI/ASPM: Fix link state exit during switch upstream function removal
Before 456d8aa37d0f ("PCI/ASPM: Disable ASPM on MFD function removal to avoid use-after-free"), we would free the ASPM link only after the last function on the bus pertaining to the given link was removed.
That was too late. If function 0 is removed before sibling function, link->downstream would point to free'd memory after.
After above change, we freed the ASPM parent link state upon any function removal on the bus pertaining to a given link.
That is too early. If the link is to a PCIe switch with MFD on the upstream port, then removing functions other than 0 first would free a link which still remains parent_link to the remaining downstream ports.
The resulting GPFs are especially frequent during hot-unplug, because pciehp removes devices on the link bus in reverse order.
On that switch, function 0 is the virtual P2P bridge to the internal bus. Free exactly when function 0 is removed -- before the parent link is obsolete, but after all subordinate links are gone.
From the CVE record · Linux
The Linux kernel's PCI/ASPM code can free a link state while downstream ports still reference it when functions on a PCIe switch's upstream port are removed. This can cause general protection faults, especially during hot-unplug. The input does not establish an attacker, authentication requirements, or user-interaction requirements.
Engineers running Linux kernels with PCIe switches that have multiple functions on an upstream port should check their systems; affected versions are not specified.