virtio-blk: don't keep queue frozen during system suspend
Linux
Affected versions
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
Linux
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
≥ 4ce6e2db00de8103a0687fb0f65fd17124a51aaa · < 92d5139b91147ab372a17daf5dc27a5b9278e516| No fix yet |
| Linux Linux |
|
|
In the Linux kernel, the following vulnerability has been resolved:
virtio-blk: don't keep queue frozen during system suspend
Commit 4ce6e2db00de ("virtio-blk: Ensure no requests in virtqueues before deleting vqs.") replaces queue quiesce with queue freeze in virtio-blk's PM callbacks. And the motivation is to drain inflight IOs before suspending.
block layer's queue freeze looks very handy, but it is also easy to cause deadlock, such as, any attempt to call into bio_queue_enter() may run into deadlock if the queue is frozen in current context. There are all kinds of ->suspend() called in suspend context, so keeping queue frozen in the whole suspend context isn't one good idea. And Marek reported lockdep warning[1] caused by virtio-blk's freeze queue in virtblk_freeze().
[1] https://lore.kernel.org/linux-block/ca16370e-d646-4eee-b9cc-87277c89c43c@samsung.com/
Given the motivation is to drain in-flight IOs, it can be done by calling freeze & unfreeze, meantime restore to previous behavior by keeping queue quiesced during suspend.
From the CVE record · Linux
The Linux kernel's virtio-blk suspend handling can leave a block queue frozen throughout system suspend. An attempt to enter that queue in the same suspend context may deadlock; a lockdep warning has been reported. The input does not describe an attacker, authentication requirement, or user interaction.
Engineers running Linux kernels with virtio-blk should check their kernel version; affected versions are not specified in the input.