fsnotify: clear PARENT_WATCHED flags lazily
Linux
Affected versions
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
Linux
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
≥ 873feea09ebc980cbd3631b767356ce1eee65ec1 · < 172e422ffea20a89bfdc672741c1aad6fbb5044e| No fix yet |
| Linux Linux |
|
|
In the Linux kernel, the following vulnerability has been resolved:
fsnotify: clear PARENT_WATCHED flags lazily
In some setups directories can have many (usually negative) dentries. Hence __fsnotify_update_child_dentry_flags() function can take a significant amount of time. Since the bulk of this function happens under inode->i_lock this causes a significant contention on the lock when we remove the watch from the directory as the __fsnotify_update_child_dentry_flags() call from fsnotify_recalc_mask() races with __fsnotify_update_child_dentry_flags() calls from __fsnotify_parent() happening on children. This can lead upto softlockup reports reported by users.
Fix the problem by calling fsnotify_update_children_dentry_flags() to set PARENT_WATCHED flags only when parent starts watching children.
When parent stops watching children, clear false positive PARENT_WATCHED flags lazily in __fsnotify_parent() for each accessed child.
From the CVE record · Linux
The Linux kernel’s fsnotify code can hold an inode lock for a significant time when removing a directory watch in setups with many child dentries. Concurrent fsnotify activity on children can cause lock contention and soft lockup reports. The input does not specify an attacker-controlled trigger, authentication requirement, or user interaction.
Engineers running Linux kernels with fsnotify directory watches should check whether their kernel is affected; affected versions are not specified.