firmware: cs_dsp: Fix overflow checking of wmfw header
Linux
Affected versions
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
| No fix yet |
| Linux Linux |
|
Linux
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
| No fix yet |
| Linux Linux |
|
|
In the Linux kernel, the following vulnerability has been resolved:
firmware: cs_dsp: Fix overflow checking of wmfw header
Fix the checking that firmware file buffer is large enough for the wmfw header, to prevent overrunning the buffer.
The original code tested that the firmware data buffer contained enough bytes for the sums of the size of the structs
wmfw_header + wmfw_adsp1_sizes + wmfw_footer
But wmfw_adsp1_sizes is only used on ADSP1 firmware. For ADSP2 and Halo Core the equivalent struct is wmfw_adsp2_sizes, which is 4 bytes longer. So the length check didn't guarantee that there are enough bytes in the firmware buffer for a header with wmfw_adsp2_sizes.
This patch splits the length check into three separate parts. Each of the wmfw_header, wmfw_adsp?_sizes and wmfw_footer are checked separately before they are used.
From the CVE record · Linux
The Linux kernel's cs_dsp firmware loader can read past a firmware buffer because its wmfw header length check does not account for the larger ADSP2 and Halo Core size structure. An attacker who can cause the kernel to process an undersized firmware file could trigger the overrun; the input does not specify the access or user interaction required.
Engineers running Linux kernels that process cs_dsp ADSP2 or Halo Core firmware should check their exposure; affected versions are not specified.