phy: ti: tusb1210: Resolve charger-det crash if charger psy is unregistered
Linux
Affected versions
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
| No fix yet |
| Linux Linux |
|
Linux
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
| No fix yet |
| Linux Linux |
|
|
In the Linux kernel, the following vulnerability has been resolved:
phy: ti: tusb1210: Resolve charger-det crash if charger psy is unregistered
The power_supply frame-work is not really designed for there to be long living in kernel references to power_supply devices.
Specifically unregistering a power_supply while some other code has a reference to it triggers a WARN in power_supply_unregister():
WARN_ON(atomic_dec_return(&psy->use_cnt));
Folllowed by the power_supply still getting removed and the backing data freed anyway, leaving the tusb1210 charger-detect code with a dangling reference, resulting in a crash the next time tusb1210_get_online() is called.
Fix this by only holding the reference in tusb1210_get_online() freeing it at the end of the function. Note this still leaves a theoretical race window, but it avoids the issue when manually rmmod-ing the charger chip driver during development.
From the CVE record · Linux
The Linux kernel’s TUSB1210 charger-detection code can retain a dangling reference after a charger power-supply device is unregistered. A subsequent call to tusb1210_get_online() can crash the kernel; the described scenario involves manually unloading the charger-chip driver during development. The input does not specify a network attack path or authentication requirements.
Engineers running Linux kernels that use the TUSB1210 charger-detection code should check their systems; affected versions are not specified.