bpf, sockmap: Prevent lock inversion deadlock in map delete elem
Linux
Affected versions
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
Linux
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
≥ 604326b41a6fb9b4a78b6179335decee0365cd8c · < 6af057ccdd8e7619960aca1f0428339f213b31cd| No fix yet |
| Linux Linux |
|
|
In the Linux kernel, the following vulnerability has been resolved:
bpf, sockmap: Prevent lock inversion deadlock in map delete elem
syzkaller started using corpuses where a BPF tracing program deletes elements from a sockmap/sockhash map. Because BPF tracing programs can be invoked from any interrupt context, locks taken during a map_delete_elem operation must be hardirq-safe. Otherwise a deadlock due to lock inversion is possible, as reported by lockdep:
CPU0 CPU1 ---- ---- lock(&htab->buckets[i].lock); local_irq_disable(); lock(&host->lock); lock(&htab->buckets[i].lock); <Interrupt> lock(&host->lock);
Locks in sockmap are hardirq-unsafe by design. We expects elements to be deleted from sockmap/sockhash only in task (normal) context with interrupts enabled, or in softirq context.
Detect when map_delete_elem operation is invoked from a context which is _not_ hardirq-unsafe, that is interrupts are disabled, and bail out with an error.
Note that map updates are not affected by this issue. BPF verifier does not allow updating sockmap/sockhash from a BPF tracing program today.
From the CVE record · Linux
The Linux kernel’s BPF sockmap/sockhash deletion path can deadlock through lock inversion when a BPF tracing program deletes a map element with interrupts disabled. The input does not specify whether exploitation requires local access, authentication, or user interaction.
Engineers running Linux kernels that use BPF tracing programs with sockmap or sockhash maps should check their exposure; affected versions are not specified.