of: dynamic: Synchronize of_changeset_destroy() with the devlink removals
Linux
Affected versions
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
Linux
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
≥ 80dd33cf72d1ab4f0af303f1fa242c6d6c8d328f · < 8917e7385346bd6584890ed362985c219fe6ae84| No fix yet |
| Linux Linux |
|
|
In the Linux kernel, the following vulnerability has been resolved:
of: dynamic: Synchronize of_changeset_destroy() with the devlink removals
In the following sequence: 1) of_platform_depopulate() 2) of_overlay_remove()
During the step 1, devices are destroyed and devlinks are removed. During the step 2, OF nodes are destroyed but __of_changeset_entry_destroy() can raise warnings related to missing of_node_put(): ERROR: memory leak, expected refcount 1 instead of 2 ...
Indeed, during the devlink removals performed at step 1, the removal itself releasing the device (and the attached of_node) is done by a job queued in a workqueue and so, it is done asynchronously with respect to function calls. When the warning is present, of_node_put() will be called but wrongly too late from the workqueue job.
In order to be sure that any ongoing devlink removals are done before the of_node destruction, synchronize the of_changeset_destroy() with the devlink removals.
From the CVE record · Linux
The Linux kernel can report an OF node reference-count leak when platform devices are depopulated before a device tree overlay is removed. Device-link removal runs asynchronously, so it may release an OF node only after the changeset destroys it. The input does not establish an attacker path, authentication requirement, or user-interaction requirement.
Engineers running Linux kernels that use dynamic device tree overlays should check whether their kernel includes the fix; affected versions were not provided.