serial/pmac_zilog: Remove flawed mitigation for rx irq flood
Linux
Affected versions
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
Linux
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
≥ 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 · < 52aaf1ff14622a04148dbb9ccce6d9de5d534ea7| No fix yet |
| Linux Linux |
|
|
In the Linux kernel, the following vulnerability has been resolved:
serial/pmac_zilog: Remove flawed mitigation for rx irq flood
The mitigation was intended to stop the irq completely. That may be better than a hard lock-up but it turns out that you get a crash anyway if you're using pmac_zilog as a serial console:
ttyPZ0: pmz: rx irq flood ! BUG: spinlock recursion on CPU#0, swapper/0
That's because the pr_err() call in pmz_receive_chars() results in pmz_console_write() attempting to lock a spinlock already locked in pmz_interrupt(). With CONFIG_DEBUG_SPINLOCK=y, this produces a fatal BUG splat. The spinlock in question is the one in struct uart_port.
Even when it's not fatal, the serial port rx function ceases to work. Also, the iteration limit doesn't play nicely with QEMU, as can be seen in the bug report linked below.
A web search for other reports of the error message "pmz: rx irq flood" didn't produce anything. So I don't think this code is needed any more. Remove it.
From the CVE record · Linux
A flawed receive-interrupt flood mitigation in the Linux kernel’s pmac_zilog driver can cause spinlock recursion when pmac_zilog is used as a serial console. With CONFIG_DEBUG_SPINLOCK enabled, this produces a fatal crash; otherwise, serial port reception can stop working. The input does not establish an attacker access path or whether authentication or user interaction is required.
Engineers running Linux with pmac_zilog as a serial console should check their kernels; affected versions are not specified.