mm: swap: fix race between free_swap_and_cache() and swapoff()
Linux
Affected versions
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
Linux
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
≥ 7c00bafee87c7bac7ed9eced7c161f8e5332cb4e · < 363d17e7f7907c8e27a9e86968af0eaa2301787b| No fix yet |
| Linux Linux |
|
|
In the Linux kernel, the following vulnerability has been resolved:
mm: swap: fix race between free_swap_and_cache() and swapoff()
There was previously a theoretical window where swapoff() could run and teardown a swap_info_struct while a call to free_swap_and_cache() was running in another thread. This could cause, amongst other bad possibilities, swap_page_trans_huge_swapped() (called by free_swap_and_cache()) to access the freed memory for swap_map.
This is a theoretical problem and I haven't been able to provoke it from a test case. But there has been agreement based on code review that this is possible (see link below).
Fix it by using get_swap_device()/put_swap_device(), which will stall swapoff(). There was an extra check in _swap_info_get() to confirm that the swap entry was not free. This isn't present in get_swap_device() because it doesn't make sense in general due to the race between getting the reference and swapoff. So I've added an equivalent check directly in free_swap_and_cache().
Details of how to provoke one possible issue (thanks to David Hildenbrand for deriving this):
--8<-----
__swap_entry_free() might be the last user and result in "count == SWAP_HAS_CACHE".
From the CVE record · Linux
A race between free_swap_and_cache() and swapoff() in the Linux kernel can allow access to freed swap_map memory. This requires concurrent swap operations; the issue was identified by code review and has not been reproduced in a test case. The input does not establish an attacker-controlled exploit path or authentication requirements.
Engineers running Linux kernels should check whether their kernel includes the fix; affected versions are not specified.