sfc: fix crash when reading stats while NIC is resetting
Linux
Affected versions
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
Linux
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
≥ d3142c193dca9a2f6878f4128ce1aaf221bb3f99 · < d1b355438b8325a486f087e506d412c4e852f37b| No fix yet |
| Linux Linux |
|
|
In the Linux kernel, the following vulnerability has been resolved:
sfc: fix crash when reading stats while NIC is resetting
efx_net_stats() (.ndo_get_stats64) can be called during an ethtool selftest, during which time nic_data->mc_stats is NULL as the NIC has been fini'd. In this case do not attempt to fetch the latest stats from the hardware, else we will crash on a NULL dereference: BUG: kernel NULL pointer dereference, address: 0000000000000038 RIP efx_nic_update_stats abridged calltrace: efx_ef10_update_stats_pf efx_net_stats dev_get_stats dev_seq_printf_stats Skipping the read is safe, we will simply give out stale stats. To ensure that the free in efx_ef10_fini_nic() does not race against efx_ef10_update_stats_pf(), which could cause a TOCTTOU bug, take the efx->stats_lock in fini_nic (it is already held across update_stats).
From the CVE record · Linux
The Linux kernel's sfc driver can dereference a NULL pointer when network statistics are read while the NIC is resetting during an ethtool self-test. This can crash the kernel; the input does not establish whether an attacker can trigger it or what access would be required.
Engineers running Linux kernels with the sfc driver should check whether their kernel includes the fix; affected versions were not specified.