hwrng: virtio - Fix race on data_avail and actual data
Linux
Affected versions
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
Linux
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
≥ f7f510ec195781c857ab76366a3e1c59e1caae42 · < 318657b4c2077289659f1cd9e2a34f6a3b208e3e| No fix yet |
| Linux Linux |
|
|
In the Linux kernel, the following vulnerability has been resolved:
hwrng: virtio - Fix race on data_avail and actual data
The virtio rng device kicks off a new entropy request whenever the data available reaches zero. When a new request occurs at the end of a read operation, that is, when the result of that request is only needed by the next reader, then there is a race between the writing of the new data and the next reader.
This is because there is no synchronisation whatsoever between the writer and the reader.
Fix this by writing data_avail with smp_store_release and reading it with smp_load_acquire when we first enter read. The subsequent reads are safe because they're either protected by the first load acquire, or by the completion mechanism.
Also remove the redundant zeroing of data_idx in random_recv_done (data_idx must already be zero at this point) and data_avail in request_entropy (ditto).
From the CVE record · Linux
The Linux kernel's virtio rng driver has a race between writing new entropy data and the next reader accessing it. It can occur when an entropy request starts at the end of a read operation and its result is needed by the next read. The input does not specify an attacker outcome or authentication requirements.
Teams running Linux kernels that use the virtio rng driver should check their versions against the vendor advisory; affected versions were not provided.