spi: bcm-qspi: return error if neither hif_mspi nor mspi is available
Linux
Affected versions
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
Linux
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
≥ fa236a7ef24048bafaeed13f68df35a819794758 · < d3dcdb43c872a3b967345144151a2c9bb9124c9b| No fix yet |
| Linux Linux |
|
|
In the Linux kernel, the following vulnerability has been resolved:
spi: bcm-qspi: return error if neither hif_mspi nor mspi is available
If neither a "hif_mspi" nor "mspi" resource is present, the driver will just early exit in probe but still return success. Apart from not doing anything meaningful, this would then also lead to a null pointer access on removal, as platform_get_drvdata() would return NULL, which it would then try to dereference when trying to unregister the spi master.
Fix this by unconditionally calling devm_ioremap_resource(), as it can handle a NULL res and will then return a viable ERR_PTR() if we get one.
The "return 0;" was previously a "goto qspi_resource_err;" where then ret was returned, but since ret was still initialized to 0 at this place this was a valid conversion in 63c5395bb7a9 ("spi: bcm-qspi: Fix use-after-free on unbind"). The issue was not introduced by this commit, only made more obvious.
From the CVE record · Linux
The Linux kernel bcm-qspi driver can report a successful probe when neither the hif_mspi nor mspi resource is present. Removing the device afterward can cause a null pointer access when the driver tries to unregister the SPI master. The input does not establish an attacker access path or authentication requirements.
Engineers running Linux kernels with the bcm-qspi driver should check their affected versions; none are specified in the input.