virtio-mmio: don't break lifecycle of vm_dev
Linux
Affected versions
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
Linux
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
≥ 7eb781b1bbb7136fe78fb8c28c1c223c61fa32b5 · < 2dcb368fe5a8eee498ca75c93a18ce2f3b0d6a8e| No fix yet |
| Linux Linux |
|
|
In the Linux kernel, the following vulnerability has been resolved:
virtio-mmio: don't break lifecycle of vm_dev
vm_dev has a separate lifecycle because it has a 'struct device' embedded. Thus, having a release callback for it is correct.
Allocating the vm_dev struct with devres totally breaks this protection, though. Instead of waiting for the vm_dev release callback, the memory is freed when the platform_device is removed. Resulting in a use-after-free when finally the callback is to be called.
To easily see the problem, compile the kernel with CONFIG_DEBUG_KOBJECT_RELEASE and unbind with sysfs.
The fix is easy, don't use devres in this case.
Found during my research about object lifetime problems.
From the CVE record · Linux
The Linux kernel's virtio-mmio driver can free vm_dev before its release callback runs, causing a use-after-free. The issue can be reproduced locally by unbinding through sysfs with CONFIG_DEBUG_KOBJECT_RELEASE enabled; the input does not specify authentication requirements.
Engineers running Linux kernels that include the affected virtio-mmio code should check their versions; affected version numbers were not provided.