NFSv4.2: Rework scratch handling for READ_PLUS (again)
Linux
Affected versions
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
| No fix yet |
| Linux Linux |
|
Linux
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
| No fix yet |
| Linux Linux |
|
|
In the Linux kernel, the following vulnerability has been resolved:
NFSv4.2: Rework scratch handling for READ_PLUS (again)
I found that the read code might send multiple requests using the same nfs_pgio_header, but nfs4_proc_read_setup() is only called once. This is how we ended up occasionally double-freeing the scratch buffer, but also means we set a NULL pointer but non-zero length to the xdr scratch buffer. This results in an oops the first time decoding needs to copy something to scratch, which frequently happens when decoding READ_PLUS hole segments.
I fix this by moving scratch handling into the pageio read code. I provide a function to allocate scratch space for decoding read replies, and free the scratch buffer when the nfs_pgio_header is freed.
From the CVE record · Linux
The Linux kernel's NFSv4.2 READ_PLUS read path can double-free a scratch buffer when multiple requests use the same read header. Decoding a READ_PLUS hole segment can then trigger a kernel oops; the input does not establish an attacker path, authentication requirement, or user-interaction requirement.
Engineers running Linux kernels that use NFSv4.2 READ_PLUS should check their versions; affected versions are not specified.