netfilter: x_tables: fix percpu counter block leak on error path when creating new netns
Linux
Affected versions
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
| No fix yet |
| Linux Linux |
|
Linux
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
| No fix yet |
| Linux Linux |
|
|
In the Linux kernel, the following vulnerability has been resolved:
netfilter: x_tables: fix percpu counter block leak on error path when creating new netns
Here is the stack where we allocate percpu counter block:
+-< __alloc_percpu +-< xt_percpu_counter_alloc +-< find_check_entry # {arp,ip,ip6}_tables.c +-< translate_table
And it can be leaked on this code path:
+-> ip6t_register_table +-> translate_table # allocates percpu counter block +-> xt_register_table # fails
there is no freeing of the counter block on xt_register_table fail. Note: xt_percpu_counter_free should be called to free it like we do in do_replace through cleanup_entry helper (or in __ip6t_unregister_table).
Probability of hitting this error path is low AFAICS (xt_register_table can only return ENOMEM here, as it is not replacing anything, as we are creating new netns, and it is hard to imagine that all previous allocations succeeded and after that one in xt_register_table failed). But it's worth fixing even the rare leak.
From the CVE record · Linux
When a new network namespace is created, an allocation failure in xt_register_table can leak a per-CPU counter block. The input describes this as a rare error path and does not establish whether an attacker can trigger it or whether authentication or user interaction is required.
Engineers running the Linux kernel should check their deployments; affected versions are not specified.