{"schemaVersion":1,"url":"https://cve.openhack.com/cve/CVE-2023-52894","id":"CVE-2023-52894","title":"usb: gadget: f_ncm: fix potential NULL ptr deref in ncm_bitrate()","description":"In the Linux kernel, the following vulnerability has been resolved:\n\nusb: gadget: f_ncm: fix potential NULL ptr deref in ncm_bitrate()\n\nIn Google internal bug 265639009 we've received an (as yet) unreproducible\ncrash report from an aarch64 GKI 5.10.149-android13 running device.\n\nAFAICT the source code is at:\n  https://android.googlesource.com/kernel/common/+/refs/tags/ASB-2022-12-05_13-5.10\n\nThe c","descriptionLong":"In the Linux kernel, the following vulnerability has been resolved:\n\nusb: gadget: f_ncm: fix potential NULL ptr deref in ncm_bitrate()\n\nIn Google internal bug 265639009 we've received an (as yet) unreproducible\ncrash report from an aarch64 GKI 5.10.149-android13 running device.\n\nAFAICT the source code is at:\n  https://android.googlesource.com/kernel/common/+/refs/tags/ASB-2022-12-05_13-5.10\n\nThe call stack is:\n  ncm_close() -> ncm_notify() -> ncm_do_notify()\nwith the crash at:\n  ncm_do_notify+0x98/0x270\nCode: 79000d0b b9000a6c f940012a f9400269 (b9405d4b)\n\nWhich I believe disassembles to (I don't know ARM assembly, but it looks sane enough to me...):\n\n  // halfword (16-bit) store presumably to event->wLength (at offset 6 of struct usb_cdc_notification)\n  0B 0D 00 79    strh w11, [x8, #6]\n\n  // word (32-bit) store presumably to req->Length (at offset 8 of struct usb_request)\n  6C 0A 00 B9    str  w12, [x19, #8]\n\n  // x10 (NULL) was read here from offset 0 of valid pointer x9\n  // IMHO we're reading 'cdev->gadget' and getting NULL\n  // gadget is indeed at offset 0 of struct usb_composite_dev\n  2A 01 40 F9    ldr  x10, [x9]\n\n  // loading req->buf pointer, which is at offset 0 of struct usb_request\n  69 02 40 F9    ldr  x9, [x19]\n\n  // x10 is null, crash, appears to be attempt to read cdev->gadget->max_speed\n  4B 5D 40 B9    ldr  w11, [x10, #0x5c]\n\nwhich seems to line up with ncm_do_notify() case NCM_NOTIFY_SPEED code fragment:\n\n  event->wLength = cpu_to_le16(8);\n  req->length = NCM_STATUS_BYTECOUNT;\n\n  /* SPEED_CHANGE data is up/down speeds in bits/sec */\n  data = req->buf + sizeof *event;\n  data[0] = cpu_to_le32(ncm_bitrate(cdev->gadget));\n\nMy analysis of registers and NULL ptr deref crash offset\n  (Unable to handle kernel NULL pointer dereference at virtual address 000000000000005c)\nheavily suggests that the crash is due to 'cdev->gadget' being NULL when executing:\n  data[0] = cpu_to_le32(ncm_bitrate(cdev->gadget));\nwhich calls:\n  ncm_bitrate(NULL)\nwhich then calls:\n  gadget_is_superspeed(NULL)\nwhich reads\n  ((struct usb_gadget *)NULL)->max_speed\nand hits a panic.\n\nAFAICT, if I'm counting right, the offset of max_speed is indeed 0x5C.\n(remember there's a GKI KABI reservation of 16 bytes in struct work_struct)\n\nIt's not at all clear to me how this is all supposed to work...\nbut returning 0 seems much better than panic-ing...","published":"2024-08-21T06:10:34.120Z","updated":"2026-10-28T02:30:30.080793722Z","reserved":"2024-08-21T06:07:11.013Z","status":"Analyzed","rejected":false,"assigner":"Linux","metric":{"version":"3.1","score":5.5,"vector":"CVSS:3.1/AV:L/AC:L/PR:L/UI:N/S:U/C:N/I:N/A:H","rating":"medium","source":"NVD"},"metrics":[{"version":"3.1","score":5.5,"vector":"CVSS:3.1/AV:L/AC:L/PR:L/UI:N/S:U/C:N/I:N/A:H","rating":"medium","source":"NVD"}],"rating":"medium","products":["Linux"],"affectedProducts":[{"vendor":"Linux","product":"Linux","defaultStatus":"unaffected","versions":[{"version":"1650113888fe7b7e16604a5019c32dd3ddeb3af2","lessThan":"fef6b29671b66dfb71f17e337c1ad14b5a2cedae","status":"affected","versionType":"git"},{"version":"1650113888fe7b7e16604a5019c32dd3ddeb3af2","lessThan":"63d161f29cd39c050e8873aa36e0c9fc013bb763","status":"affected","versionType":"git"},{"version":"1650113888fe7b7e16604a5019c32dd3ddeb3af2","lessThan":"a21da7f7aae618c785f7e4a275d43c06dc8412b6","status":"affected","versionType":"git"},{"version":"1650113888fe7b7e16604a5019c32dd3ddeb3af2","lessThan":"e92c70059178da751e5af7de02384b7dfadb5ec7","status":"affected","versionType":"git"},{"version":"1650113888fe7b7e16604a5019c32dd3ddeb3af2","lessThan":"a69c8dfb85b44be9cc223be07d35cc3a9baefbea","status":"affected","versionType":"git"},{"version":"1650113888fe7b7e16604a5019c32dd3ddeb3af2","lessThan":"09e4507ec8ef2d44da6ba4092b8ee2d81f216497","status":"affected","versionType":"git"},{"version":"1650113888fe7b7e16604a5019c32dd3ddeb3af2","lessThan":"c6ec929595c7443250b2a4faea988c62019d5cd2","status":"affected","versionType":"git"}],"platforms":[]},{"vendor":"Linux","product":"Linux","defaultStatus":"affected","versions":[{"version":"4.9","status":"affected"},{"version":"0","lessThan":"4.9","status":"unaffected","versionType":"semver"},{"version":"4.14.304","lessThanOrEqual":"4.14.*","status":"unaffected","versionType":"semver"},{"version":"4.19.271","lessThanOrEqual":"4.19.*","status":"unaffected","versionType":"semver"},{"version":"5.4.230","lessThanOrEqual":"5.4.*","status":"unaffected","versionType":"semver"},{"version":"5.10.165","lessThanOrEqual":"5.10.*","status":"unaffected","versionType":"semver"},{"version":"5.15.90","lessThanOrEqual":"5.15.*","status":"unaffected","versionType":"semver"},{"version":"6.1.8","lessThanOrEqual":"6.1.*","status":"unaffected","versionType":"semver"},{"version":"6.2","lessThanOrEqual":"*","status":"unaffected","versionType":"original_commit_for_fix"}],"platforms":[]}],"packages":[],"cwes":["CWE-476"],"aliases":[],"references":[{"url":"https://git.kernel.org/stable/c/fef6b29671b66dfb71f17e337c1ad14b5a2cedae","tags":["Patch","web"]},{"url":"https://git.kernel.org/stable/c/63d161f29cd39c050e8873aa36e0c9fc013bb763","tags":["Patch","web"]},{"url":"https://git.kernel.org/stable/c/a21da7f7aae618c785f7e4a275d43c06dc8412b6","tags":["Patch","web"]},{"url":"https://git.kernel.org/stable/c/e92c70059178da751e5af7de02384b7dfadb5ec7","tags":["Patch","web"]},{"url":"https://git.kernel.org/stable/c/a69c8dfb85b44be9cc223be07d35cc3a9baefbea","tags":["Patch","web"]},{"url":"https://git.kernel.org/stable/c/09e4507ec8ef2d44da6ba4092b8ee2d81f216497","tags":["Patch","web"]},{"url":"https://git.kernel.org/stable/c/c6ec929595c7443250b2a4faea988c62019d5cd2","tags":["Patch","web"]},{"url":"https://github.com/CVEProject/cvelistV5/tree/main/cves/2023/52xxx/CVE-2023-52894.json","tags":["advisory"]},{"url":"https://nvd.nist.gov/vuln/detail/CVE-2023-52894","tags":["advisory"]},{"url":"https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git","tags":["package"]}],"patchReferenced":true,"fixAvailable":true,"exploitReferenced":false,"kev":false,"kevAdded":null,"kevDue":null,"kevEntry":null,"ssvc":{"exploitation":"none","automatable":"no","technicalImpact":"partial"},"epss":0.00243,"epssPercentile":0.1564,"sources":[{"name":"CVE List","url":"https://www.cve.org/CVERecord?id=CVE-2023-52894","ok":true},{"name":"NVD","url":"https://nvd.nist.gov/vuln/detail/CVE-2023-52894","ok":true,"note":"Analyzed"},{"name":"OSV","url":"https://osv.dev/vulnerability/CVE-2023-52894","ok":true,"note":"0 packages"},{"name":"CISA KEV","url":"https://www.cisa.gov/known-exploited-vulnerabilities-catalog","ok":true,"note":"not listed"},{"name":"EPSS","url":"https://api.first.org/data/v1/epss?cve=CVE-2023-52894","ok":true,"note":"scored 2026-11-19"}],"aiTitle":false,"tech":[],"critical":[],"attention":null}