btrfs: remove BUG() after failure to insert delayed dir index item
Linux
Affected versions
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
| No fix yet |
| Linux Linux |
Linux
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
| No fix yet |
| Linux Linux |
|
|
In the Linux kernel, the following vulnerability has been resolved:
btrfs: remove BUG() after failure to insert delayed dir index item
Instead of calling BUG() when we fail to insert a delayed dir index item into the delayed node's tree, we can just release all the resources we have allocated/acquired before and return the error to the caller. This is fine because all existing call chains undo anything they have done before calling btrfs_insert_delayed_dir_index() or BUG_ON (when creating pending snapshots in the transaction commit path).
So remove the BUG() call and do proper error handling.
This relates to a syzbot report linked below, but does not fix it because it only prevents hitting a BUG(), it does not fix the issue where somehow we attempt to use twice the same index number for different index items.
From the CVE record · Linux
The Linux kernel's btrfs code can call BUG() if it fails to insert a delayed directory index item, potentially crashing the kernel. The input does not specify whether triggering this requires local or network access, authentication, or user interaction. The change removes the BUG() call but does not fix the underlying duplicate-index issue described in the report.
Engineers running Linux kernels with btrfs should check their kernel versions against the Linux kernel advisory; affected versions are not specified in the input.