drm: Don't unref the same fb many times by mistake due to deadlock handling
Linux
Affected versions
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
Linux
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
≥ 29dc0d1de18239cf3ef8bab578b8321ed340d81c · < d7afdf360f4ac142832b098b4de974e867cc063c| No fix yet |
| Linux Linux |
|
|
In the Linux kernel, the following vulnerability has been resolved:
drm: Don't unref the same fb many times by mistake due to deadlock handling
If we get a deadlock after the fb lookup in drm_mode_page_flip_ioctl() we proceed to unref the fb and then retry the whole thing from the top. But we forget to reset the fb pointer back to NULL, and so if we then get another error during the retry, before the fb lookup, we proceed the unref the same fb again without having gotten another reference. The end result is that the fb will (eventually) end up being freed while it's still in use.
Reset fb to NULL once we've unreffed it to avoid doing it again until we've done another fb lookup.
This turned out to be pretty easy to hit on a DG2 when doing async flips (and CONFIG_DEBUG_WW_MUTEX_SLOWPATH=y). The first symptom I saw that drm_closefb() simply got stuck in a busy loop while walking the framebuffer list. Fortunately I was able to convince it to oops instead, and from there it was easier to track down the culprit.
From the CVE record · Linux
The Linux kernel’s DRM page-flip ioctl can release the same framebuffer reference twice if a deadlock causes a retry and another error occurs before the next framebuffer lookup. A local caller who triggers this sequence can cause the framebuffer to be freed while it is still in use; the report describes a busy loop and a kernel oops.
Engineers running Linux kernels with DRM page-flip support should check their kernel against the vendor advisory; affected versions are not specified.