EDAC/thunderx: Fix possible out-of-bounds string access
Linux
Affected versions
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
Linux
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
≥ 41003396f932d7f027725c7acebb6a7caa41dc3e · < e1c86511241588efffaa49556196f09a498d5057| No fix yet |
| Linux Linux |
|
|
In the Linux kernel, the following vulnerability has been resolved:
EDAC/thunderx: Fix possible out-of-bounds string access
Enabling -Wstringop-overflow globally exposes a warning for a common bug in the usage of strncat():
drivers/edac/thunderx_edac.c: In function 'thunderx_ocx_com_threaded_isr': drivers/edac/thunderx_edac.c:1136:17: error: 'strncat' specified bound 1024 equals destination size [-Werror=stringop-overflow=] 1136 | strncat(msg, other, OCX_MESSAGE_SIZE); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ... 1145 | strncat(msg, other, OCX_MESSAGE_SIZE); ... 1150 | strncat(msg, other, OCX_MESSAGE_SIZE);
...
Apparently the author of this driver expected strncat() to behave the way that strlcat() does, which uses the size of the destination buffer as its third argument rather than the length of the source buffer. The result is that there is no check on the size of the allocated buffer.
Change it to strlcat().
[ bp: Trim compiler output, fixup commit message. ]
From the CVE record · Linux
The Linux kernel’s EDAC/thunderx driver uses strncat() without checking the remaining space in its message buffer, allowing possible out-of-bounds string access. The input does not establish how an attacker could trigger the issue or whether access, authentication, or user interaction is required.
Engineers running Linux kernels with the EDAC/thunderx driver should check their versions; affected versions are not specified.