GovernorCompatibilityBravo may trim proposal calldata
openzeppelin-contracts
Affected versions
| Product | Affected | Fixed in |
|---|---|---|
| @openzeppelin/contracts npm |
|
|
| @openzeppelin/contracts-upgradeable npm |
|
|
openzeppelin-contracts
| Product | Affected | Fixed in |
|---|---|---|
| @openzeppelin/contracts npm |
|
|
| @openzeppelin/contracts-upgradeable npm |
|
|
OpenZeppelin Contracts is a library for secure smart contract development. The proposal creation entrypoint (`propose`) in `GovernorCompatibilityBravo` allows the creation of proposals with a `signatures` array shorter than the `calldatas` array. This causes the additional elements of the latter to be ignored, and if the proposal succeeds the corresponding actions would eventually execute without any calldata. The `ProposalCreated` event correctly represents what will eventually execute, but the proposal parameters as queried through `getActions` appear to respect the original intended calldata. This issue has been patched in 4.8.3. As a workaround, ensure that all proposals that pass through governance have equal length `signatures` and `calldatas` parameters.
From the CVE record · GitHub_M
GovernorCompatibilityBravo accepts proposals whose `signatures` array is shorter than their `calldatas` array. An attacker can create such a proposal; if it succeeds, the affected actions execute without calldata, even though `getActions` appears to show the intended calldata. The input does not specify authentication requirements.
Teams using npm `@openzeppelin/contracts` or `@openzeppelin/contracts-upgradeable` versions >=4.3.0 and <4.8.3 should check their governance deployments.