dmaengine: qcom-adm: fix wrong calling convention for prep_slave_sg
Linux
Affected versions
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
| No fix yet |
| Linux Linux |
|
|
Linux
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
| No fix yet |
| Linux Linux |
|
|
5.19.176.0.36.1In the Linux kernel, the following vulnerability has been resolved:
dmaengine: qcom-adm: fix wrong calling convention for prep_slave_sg
The calling convention for pre_slave_sg is to return NULL on error and provide an error log to the system. Qcom-adm instead provide error pointer when an error occur. This indirectly cause kernel panic for example for the nandc driver that checks only if the pointer returned by device_prep_slave_sg is not NULL. Returning an error pointer makes nandc think the device_prep_slave_sg function correctly completed and makes the kernel panics later in the code.
While nandc is the one that makes the kernel crash, it was pointed out that the real problem is qcom-adm not following calling convention for that function.
To fix this, drop returning error pointer and return NULL with an error log.
From the CVE record · Linux
The Linux kernel's qcom-adm dmaengine driver returns an error pointer where callers expect NULL on failure. If the nandc driver encounters that error, it can treat the operation as successful and later trigger a kernel panic. The input does not specify an attacker path, authentication requirements, or user interaction.
Teams running Linux kernels with the qcom-adm dmaengine driver should check their deployments; affected versions are not specified.