net: rds: don't hold sock lock when cancelling work from rds_tcp_reset_callbacks()
Linux
Affected versions
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
Linux
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
≥ ac3615e7f3cffe2a1a6b25172dfd09e138593d82 · < 30bfa5aa7228eb1e67663d67e553627e572cc717| No fix yet |
| Linux Linux |
|
|
In the Linux kernel, the following vulnerability has been resolved:
net: rds: don't hold sock lock when cancelling work from rds_tcp_reset_callbacks()
syzbot is reporting lockdep warning at rds_tcp_reset_callbacks() [1], for commit ac3615e7f3cffe2a ("RDS: TCP: Reduce code duplication in rds_tcp_reset_callbacks()") added cancel_delayed_work_sync() into a section protected by lock_sock() without realizing that rds_send_xmit() might call lock_sock().
We don't need to protect cancel_delayed_work_sync() using lock_sock(), for even if rds_{send,recv}_worker() re-queued this work while __flush_work() from cancel_delayed_work_sync() was waiting for this work to complete, retried rds_{send,recv}_worker() is no-op due to the absence of RDS_CONN_UP bit.
From the CVE record · Linux
The Linux kernel’s RDS TCP callback reset path can trigger a lockdep warning when it cancels delayed work while holding a socket lock. The input does not establish what an attacker could do or whether triggering this requires network access, authentication, or user interaction.
Engineers running Linux kernels with RDS TCP support should check their systems; affected versions are not specified.