net: ethernet: ti: Fix return type of netcp_ndo_start_xmit()
Linux
Affected versions
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
Linux
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
≥ 84640e27f23041d474c31d3362c3e2185ad68ec2 · < a413ebb6049edd881c6427cfa25a7efddd6a4f74| No fix yet |
| Linux Linux |
|
|
In the Linux kernel, the following vulnerability has been resolved:
net: ethernet: ti: Fix return type of netcp_ndo_start_xmit()
With clang's kernel control flow integrity (kCFI, CONFIG_CFI_CLANG), indirect call targets are validated against the expected function pointer prototype to make sure the call target is valid to help mitigate ROP attacks. If they are not identical, there is a failure at run time, which manifests as either a kernel panic or thread getting killed. A proposed warning in clang aims to catch these at compile time, which reveals:
drivers/net/ethernet/ti/netcp_core.c:1944:21: error: incompatible function pointer types initializing 'netdev_tx_t (*)(struct sk_buff *, struct net_device *)' (aka 'enum netdev_tx (*)(struct sk_buff *, struct net_device *)') with an expression of type 'int (struct sk_buff *, struct net_device *)' [-Werror,-Wincompatible-function-pointer-types-strict] .ndo_start_xmit = netcp_ndo_start_xmit, ^~~~~~~~~~~~~~~~~~~~ 1 error generated.
->ndo_start_xmit() in 'struct net_device_ops' expects a return type of 'netdev_tx_t', not 'int'. Adjust the return type of netcp_ndo_start_xmit() to match the prototype's to resolve the warning and CFI failure.
From the CVE record · Linux
The Linux kernel’s TI Ethernet netcp driver has a function return type that does not match the expected network-device callback prototype. With clang kernel control flow integrity enabled, an indirect call can fail at runtime, causing a kernel panic or killing a thread. The input does not establish whether an attacker can trigger this, or specify network or local access, authentication, or user-interaction requirements.
Engineers running Linux kernels with the TI Ethernet netcp driver and clang kernel control flow integrity enabled should check their deployments; affected versions are not specified.