btrfs: fix race between quota enable and quota rescan ioctl
Linux
Affected versions
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
Linux
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
≥ 5d23515be66904fa3b1b5d6bd72d2199cd2447ab · < 6c22f86dd221eba0c7af645b1af73dcbc04ee27b| No fix yet |
| Linux Linux |
|
|
In the Linux kernel, the following vulnerability has been resolved:
btrfs: fix race between quota enable and quota rescan ioctl
When enabling quotas, at btrfs_quota_enable(), after committing the transaction, we change fs_info->quota_root to point to the quota root we created and set BTRFS_FS_QUOTA_ENABLED at fs_info->flags. Then we try to start the qgroup rescan worker, first by initializing it with a call to qgroup_rescan_init() - however if that fails we end up freeing the quota root but we leave fs_info->quota_root still pointing to it, this can later result in a use-after-free somewhere else.
We have previously set the flags BTRFS_FS_QUOTA_ENABLED and BTRFS_QGROUP_STATUS_FLAG_ON, so we can only fail with -EINPROGRESS at btrfs_quota_enable(), which is possible if someone already called the quota rescan ioctl, and therefore started the rescan worker.
So fix this by ignoring an -EINPROGRESS and asserting we can't get any other error.
From the CVE record · Linux
A race between enabling btrfs quotas and starting a quota rescan through an ioctl can leave a pointer to a freed quota root. A concurrent local quota rescan can trigger this condition, potentially causing a later use-after-free. The input does not specify authentication or privilege requirements.
Engineers running Linux kernels with btrfs should check their systems; affected versions are not specified.