ethtool: strset: fix message length calculation
Linux
Affected versions
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
| No fix yet |
| Linux Linux |
|
|
Linux
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
| No fix yet |
| Linux Linux |
|
|
5.10.465.12.135.13In the Linux kernel, the following vulnerability has been resolved:
ethtool: strset: fix message length calculation
Outer nest for ETHTOOL_A_STRSET_STRINGSETS is not accounted for. This may result in ETHTOOL_MSG_STRSET_GET producing a warning like:
calculated message payload length (684) not sufficient WARNING: CPU: 0 PID: 30967 at net/ethtool/netlink.c:369 ethnl_default_doit+0x87a/0xa20
and a splat.
As usually with such warnings three conditions must be met for the warning to trigger: - there must be no skb size rounding up (e.g. reply_size of 684); - string set must be per-device (so that the header gets populated); - the device name must be at least 12 characters long.
all in all with current user space it looks like reading priv flags is the only place this could potentially happen. Or with syzbot :)
From the CVE record · Linux
The Linux kernel's ethtool string-set handler can miscalculate a reply message's length, causing a kernel warning and splat. This can occur when a per-device string set is read, the device name is at least 12 characters long, and the reply buffer size is not rounded up. The input does not specify authentication requirements or whether the issue is reachable over a network.
Engineers running the Linux kernel should check affected versions; none are specified in the input.