userfaultfd: release page in error path to avoid BUG_ON
Linux
Affected versions
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
Linux
| Product | Affected | Fixed in |
|---|---|---|
| Linux Linux |
|
≥ cb658a453b9327ce96ce5222c24d162b5b65b564 · < 2d59a0ed8b26b8f3638d8afc31f839e27759f1f6| No fix yet |
| Linux Linux |
|
|
In the Linux kernel, the following vulnerability has been resolved:
userfaultfd: release page in error path to avoid BUG_ON
Consider the following sequence of events:
1. Userspace issues a UFFD ioctl, which ends up calling into shmem_mfill_atomic_pte(). We successfully account the blocks, we shmem_alloc_page(), but then the copy_from_user() fails. We return -ENOENT. We don't release the page we allocated. 2. Our caller detects this error code, tries the copy_from_user() after dropping the mmap_lock, and retries, calling back into shmem_mfill_atomic_pte(). 3. Meanwhile, let's say another process filled up the tmpfs being used. 4. So shmem_mfill_atomic_pte() fails to account blocks this time, and immediately returns - without releasing the page.
This triggers a BUG_ON in our caller, which asserts that the page should always be consumed, unless -ENOENT is returned.
To fix this, detect if we have such a "dangling" page when accounting fails, and if so, release it before returning.
From the CVE record · Linux
A page-handling error in the Linux kernel’s userfaultfd path can trigger a BUG_ON. A local user can reach this condition through a UFFD ioctl if a userspace copy fails, the operation is retried, and tmpfs fills before the retry. No network access is described.
Engineers running the Linux kernel should check their versions against the vendor advisory; affected versions are not specified in the input.